Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in paths and avoid move operation risks #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Josecespedesant
Copy link

Hello! I was taking a look at some of the issues in this repository

Regarding the issue #9, I found this discussion that states files can get corrupted if the destination folder doesn't exists

In the discussion is suggested to use this validation before actually moving a file:

if not os.path.exists(path_destination) and os.path.isdir(path_destination):
    continue

Also I saw #6 and #5 and I believe the changes in how paths are created to use os.path.join might help with those issues

@mehanix
Copy link
Owner

mehanix commented Oct 24, 2024

Hi Jose,

Thank you very much for your contribution. I'm sorry for not responding in a timely manner - I did not get notified at all that you created this PR, not sure why. This looks great at a first glance - I'll take a look at it over the weekend and test it out.

I haven't shown this project much love in a while. Do you think it would be useful to you/a subset of people? I was thinking whether to start working on it again, get it in better shape, and maybe share it on some tech enthusiast forums (HN, the likes).

@Josecespedesant
Copy link
Author

Hi Nicoleta! To be fair I was looking through some GitHub repositories and found this project, and the idea was appealing so I decided to go ahead and see where I could help a bit. I think it might be a good resource for people who have their Downloads folder too crowded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants